chore(tools): improve tool implementation and fix bugs #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated internal project maintenance tools to be more robust and predictable. Key changes: - `fs_read_file`: Fixed line indexing to be 1-based and added validation for `start_line` and `end_line` parameters. Corrected the line collection logic to preserve line breaks. - `fs_modify_file`: Removed implicit newline consumption when matching patterns, which was causing double-newline issues or incorrect deletions. - `cargo_check`: Refactored to return structured `Outcome` results and improved output formatting. - General refactoring of tool return types to use a unified `ToolResult` type for better error handling and consistency. Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Signed-off-by: Jean Mertz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated internal project maintenance tools to be more robust and predictable.
Key changes:
fs_read_file: Fixed line indexing to be 1-based and added validation forstart_lineandend_lineparameters. Corrected the line collection logic to preserve line breaks.fs_modify_file: Removed implicit newline consumption when matching patterns, which was causing double-newline issues or incorrect deletions.cargo_check: Refactored to return structuredOutcomeresults and improved output formatting.ToolResulttype for better error handling and consistency.