This repository was archived by the owner on Aug 16, 2023. It is now read-only.
Compatibility with Rails LTS 2.3.18.16#19
Open
triskweline wants to merge 7 commits intodchelimsky:masterfrom
Open
Compatibility with Rails LTS 2.3.18.16#19triskweline wants to merge 7 commits intodchelimsky:masterfrom
triskweline wants to merge 7 commits intodchelimsky:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I apologize for making a PR for this very old branch.
We are still maintaining Rails 2.3. A patch CVE-2016-2098 has changed the default render type of
render 'template'(it used to berender :file => 'template').This also breaks the
render_templatematcher in this gem, which overrides therendermethod in ActionController to track which template has been rendered.The attached commit repairs that matcher for recent versions of Rails LTS (1 line changed).
I wonder if you can be bothered to
rake releasethis as a new version 1.3.5?Again, sorry for this blast from the past.