Skip to content

Feature: Add request hooks #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 2, 2021
Merged

Feature: Add request hooks #36

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed7968c
Add request enchancers
igoroctaviano May 3, 2021
939c60c
Pass metadata info
igoroctaviano May 5, 2021
ce37d7e
Update naming and documentation
igoroctaviano May 5, 2021
a6f85ca
Add unit tests
igoroctaviano May 6, 2021
94d33c5
CR Updates
igoroctaviano May 12, 2021
6fa48f1
CR Updates: add runtime checks
igoroctaviano May 12, 2021
99d0f6b
Merge branch 'master' of github.com:dcmjs-org/dicomweb-client into fe…
igoroctaviano May 12, 2021
4b9b26a
cr update: add examples
igoroctaviano May 17, 2021
b7443d9
Merge branch 'master' of github.com:dcmjs-org/dicomweb-client into fe…
igoroctaviano May 27, 2021
3eb39eb
CR Updates
igoroctaviano Jun 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion karma.conf.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ module.exports = function(config) {

// frameworks to use
// available frameworks: https://npmjs.org/browse/keyword/karma-adapter
frameworks: ['mocha', 'chai'],
frameworks: ['jasmine'],


// list of files / patterns to load in the browser
Expand Down
137 changes: 11 additions & 126 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,17 @@
"devDependencies": {
"@babel/core": "^7.1.0",
"@babel/preset-env": "^7.1.0",
"chai": "^4.1.2",
"eslint": "^5.16.0",
"eslint-config-airbnb-base": "^13.1.0",
"eslint-plugin-import": "^2.16.0",
"karma": "^4.2.0",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^2.2.0",
"karma-mocha": "^1.3.0",
"mocha": "^5.2.0",
"karma-jasmine": "^4.0.1",
"prettier": "^1.16.4",
"puppeteer": "^1.18.1",
"rollup": "^0.63.2",
"rollup-plugin-babel": "^4.0.3"
}
},
"dependencies": {}
}
11 changes: 9 additions & 2 deletions src/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,6 +187,7 @@ class DICOMwebClient {
}

if (requestInterceptors) {
console.debug('yes')
const metadata = { method, url };
const pipeRequestInterceptors = functions => (args) => functions.reduce((args, fn) => fn(args, metadata), args);
Copy link
Member

@hackermd hackermd May 6, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding a couple of runtime checks here

Copy link
Contributor Author

@igoroctaviano igoroctaviano May 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Let me know if I should add more. Thanks.

const pipedRequest = pipeRequestInterceptors(requestInterceptors);
Expand All @@ -212,7 +213,10 @@ class DICOMwebClient {
* @private
*/
_httpGet(url, headers, responseType, progressCallback) {
return this._httpRequest(url, "get", headers, { responseType, progressCallback });
return this._httpRequest(url, "get", headers, {
responseType,
progressCallback
});
}

/**
Expand Down Expand Up @@ -648,7 +652,10 @@ class DICOMwebClient {
* @returns {Promise} Response
*/
_httpPost(url, headers, data, progressCallback) {
return this._httpRequest(url, "post", headers, { data, progressCallback });
return this._httpRequest(url, "post", headers, {
data,
progressCallback
});
}

/**
Expand Down
Loading