Add anyref feature and type #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
Reminds me that those error diffs are, well, not so useful :) |
tlively
approved these changes
Sep 9, 2020
tlively
left a comment
tlively
left a comment
There was a problem hiding this comment.
Looks good! Let's go ahead and merge the previous PR and this one shortly thereafter.
| SmallVector<Type, 2> options; | ||
| options.push_back(type); // includes itself | ||
| // TODO (GC): subtyping | ||
| if (wasm.features.hasReferenceTypes()) { |
There was a problem hiding this comment.
Let's push this if down inside of the anyref case of the switch so the switch can be at the top level.
Owner
Author
There was a problem hiding this comment.
Addressed in the rebased PR :)
Comment on lines
+1
to
+3
| (module | ||
| (global $g (mut anyref) (ref.null any)) | ||
| ) |
There was a problem hiding this comment.
I don't think this file needs to be checked in.
Owner
Author
There was a problem hiding this comment.
Removed this file in the rebased PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a custom
--enable-anyreffeature that allows us to test subtyping relationship ofexternref,funcrefandexnrefwithout having to enable the full set of GC features.