Conversation
takirala
force-pushed
the
tga/remove-zip-universe
branch
from
fe6e15b to
40079dd
Compare
takirala
commented
Apr 4, 2019
| } | ||
| } | ||
| }.rescue { | ||
| case ce: CosmosException if ce.error.isInstanceOf[Unauthorized] => |
Contributor
Author
There was a problem hiding this comment.
Context : Currently cosmos does not have any sort of authz. It relies on AR to forward an auth token which it uses when it is talking to marathon (or any other service). If the uninstall does not complete before the auth token expires, cosmos will keep polling marathon with the expired token. We should fail fast when this happens.
Ideally, cosmos can implement authz and refresh the token on expiry. But until then, we can stop retrying when we know retry will fail. See this slack convo https://mesosphere.slack.com/archives/CAA1Z7NKT/p1553816267233400 on how it affected MWT. cc @timcharper
alenkacz
approved these changes
Apr 5, 2019
Contributor
alenkacz
left a comment
alenkacz
left a comment
There was a problem hiding this comment.
Less code is always better :D! 👍
kvish
approved these changes
Apr 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCOS_OSS-5013
This is for 1.12 and above. We stopped supporting zip universes starting 1.8 and this PR removes the deadcode. This is needed to removed unnecessary metrics (See #771 ). This also bring couple other changes: