Skip to content

fix cross compilation #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Emilgardis wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix cross compilation #16

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd87d38
Use the cargo-supplied RUSTC environment variable.
cfrantz Dec 10, 2021
220890f
correctly cross compile in buildscript
Emilgardis Nov 21, 2023
808a604
don't set linker unless it's been specified
Emilgardis Nov 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 43 additions & 9 deletions build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ use std::process::Command;

use std::io::prelude::*;

fn check_func(function_name: &str) -> bool {
fn check_func(function_name: &str, lib: pkg_config::Library) -> bool {
let out_dir = env::var_os("OUT_DIR").unwrap();
let test_file_name = Path::new(&out_dir).join(format!("check_{}.rs", function_name));

Expand All @@ -24,20 +24,54 @@ fn check_func(function_name: &str) -> bool {
writeln!(&mut test_file, " }}").unwrap();
writeln!(&mut test_file, "}}").unwrap();
}
let rustc = env::var("RUSTC").unwrap();
let mut cmd = Command::new(rustc);

let output = Command::new("rustc").
arg(&test_file_name).
arg("--out-dir").arg(&out_dir).
arg("-l").arg("udev").
output().unwrap();
cmd.arg(&test_file_name).arg("--out-dir").arg(&out_dir);

output.status.success()
for path in lib.link_paths {
cmd.arg("-L").arg(path);
}

for lib in lib.libs {
cmd.arg("-l").arg(lib);
}

cmd.args(["--target", &std::env::var("TARGET").unwrap()]);
cmd.args([
"-C",
&format!("linker={}", std::env::var("RUSTC_LINKER").unwrap()),
]);

let output = cmd.output().unwrap();
if !output.status.success() {
println!(
"cargo:warning=Failed to compile test program for udev function `{}`",
function_name
);
println!("cargo:warning=Using command`{:?}`", cmd);
println!(
"cargo:warning=stdout={}",
String::from_utf8_lossy(&output.stdout)
.trim()
.replace("\n", "\ncargo:warning=")
);
println!(
"cargo:warning=stderr={}",
String::from_utf8_lossy(&output.stderr)
.trim()
.replace("\n", "\ncargo:warning=")
);
false
} else {
true
}
Comment on lines +47 to +67
Copy link
Author

@Emilgardis Emilgardis Nov 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this might be a bit noisy if the function is not expected to work. would be better if this crate instead of checking if udev_hwdb_new works, include hwdb unconditionally if feature flag hwdb is included, and let the normal rustc invocation fail linking

}

fn main() {
pkg_config::find_library("libudev").unwrap();
let lib = pkg_config::probe_library("libudev").unwrap();

if check_func("udev_hwdb_new") {
if check_func("udev_hwdb_new", lib) {
println!("cargo:rustc-cfg=hwdb");
println!("cargo:hwdb=true");
}
Expand Down