Jetpack CRM: Ensure admin color schemes have at least 4 color entries#55
Closed
dd32 wants to merge 2 commits intoproductionfrom
Closed
Jetpack CRM: Ensure admin color schemes have at least 4 color entries#55dd32 wants to merge 2 commits intoproductionfrom
dd32 wants to merge 2 commits intoproductionfrom
Conversation
Workaround for zero-bs-crm accessing index 3 of admin color scheme colors array when some schemes only define 3 colors. Only applies when CRM is active (ZBS_PLUGIN_DIR defined). See Automattic/jetpack#47143 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- One argument per line in multi-line function calls - Avoid count() inside loop condition Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jetpack-tweaks/crm.phpfile with a workaround for zero-bs-crm accessing index 3 of$_wp_admin_css_colors[scheme]->colorswhen some color schemes only define 3 colors.ZBS_PLUGIN_DIRdefined).Test plan
🤖 Generated with Claude Code