You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Do you think it would be possible to include sonarqube check as part of GH Actions? Would be nice to have some kind of badge or any other SonarQube verification on top of this Repo for better security feeling
Do you think it would be possible to include sonarqube check as part of GH Actions? Would be nice to have some kind of badge or any other SonarQube verification on top of this Repo for better security feeling
I'm using my own SonarQube subscription here, I don't know if there's a 'free' SQ github action available.
However, the majority of these findings can also be found using a stricter eslint config. Might be best to look at that in the shorter term.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains some ESlint fixes, plus some minor improvements (most were SonarQube suggestions):
e.stack.split("\n").slice(0, 2).join("\n") + "\n" + err.stack;expressions, because they had no effecttoPrimitedTypetotoPrimitiveType(typo)if ... else { if .... }toif ... else if .... else iftype ? type : parseDefinition(...)with more concisetype ?? parseDefinition(...)allMethodsedit: the eslint things are also handled in #81, I might rebase after that one gets merged