fix: quote $DDEV_SITE_PATH to handle paths with spaces, fixes #85 #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unquoted variable caused commands in scripts to fail when the site path contained spaces. Quoting ensures the path is treated as a single argument. closes ddev#85
rfay
reviewed
Aug 3, 2025
rfay
changed the title
tyler36
approved these changes
Aug 4, 2025
There was a problem hiding this comment.
Looks good to me.
Test
-
Create project with space in name.
mkdir 'foo bar' cd 'foo bar' ddev config --project-type=wordpress --project-name=foobar ddev wp core download
-
Install addon
ddev addon get LukasFritzeDev-ddev-browsersync-58d55ef.tar.gz
-
Start addon
ddev browsersync
-
Confirm 'Browsersync: connected' appears in browser when visiting "https://foobar.ddev.site:3000"
-
Remove footer from "./wp-content/themes/twentytwentyfive/templates/home.html" and confirm site auto-reloads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unquoted variable caused commands in scripts to fail when the site path contained spaces. Quoting ensures the path is treated as a single argument.
closes #85
The Issue