fix: move WSL commandline patching into runProcess#524
Merged
Conversation
AkibaAT
force-pushed
the
bug/521-no-progress-indicator
branch
from
a486c23 to
131dbf4
Compare
AkibaAT
force-pushed
the
bug/521-no-progress-indicator
branch
from
fca48a3 to
131dbf4
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Problem/Issue/Bug:
Timing issue on Windows, when the project and Docker are on WSL, and the DDEV check command is started before a progress indicator has been created by another process
How this PR Solves the Problem:
Move the commandline patching into the runProcess where we have a EmptyProgressIndicator created beforehand
Manual Testing Instructions:
Install ddev-intellij-plugin-0.0.1-dev.zip
Related Issue Link(s):