fix: Use explicit paths in install.yaml instead of assuming pwd#126
Draft
fix: Use explicit paths in install.yaml instead of assuming pwd#126
Conversation
stasadev
reviewed
Jul 30, 2024
| drupal9) | ||
| mkdir -p .drush | ||
| drupal*) | ||
| mkdir -p ${DDEV_APPROOT}/.drush |
Member
There was a problem hiding this comment.
Suggested change
| mkdir -p ${DDEV_APPROOT}/.drush | |
| mkdir -p ${DDEV_APPROOT}/.ddev/.drush |
| read platform_project | ||
| echo "platform_project = '${platform_project}'" | ||
| # Put the platform_project in to the project's web environment | ||
| cd ${DDEV_APPROOT} |
Member
There was a problem hiding this comment.
I thought it would not make impact on ddev config. So more add-ons will be affected.
Given this, maybe changing the pre_install_actions context to .ddev is too disruptive?
(There is one more ddev config inside this yaml, that call ddev config, that you didn't change.)
stasadev
reviewed
Jul 30, 2024
Member
stasadev
left a comment
stasadev
left a comment
There was a problem hiding this comment.
cd ${DDEV_APPROOT} can be removed, and I like the more explicit changes in post_install_actions, it's always hard to guess what directory you're in without the full path.
| read platform_project | ||
| echo "platform_project = '${platform_project}'" | ||
| # Put the platform_project in to the project's web environment | ||
| cd ${DDEV_APPROOT} |
Member
There was a problem hiding this comment.
Suggested change
| cd ${DDEV_APPROOT} |
| #ddev-description:Setting PLATFORM_APPLICATION_NAME | ||
| if !( {{ contains "PLATFORM_APPLICATION_NAME" (list .DdevProjectConfig.web_environment | toString) }} ); then | ||
| # Put the platform_project in to the project's web environment | ||
| cd ${DDEV_APPROOT} |
Member
There was a problem hiding this comment.
Suggested change
| cd ${DDEV_APPROOT} |
Member
Author
|
Looks like I lost track of this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
The install.yaml makes many assumptions about what directory we're in in pre_install_hooks, post_install_hooks, and yaml_read_files
Except...
yaml_read_filescannot currently be made explicit.How This PR Solves The Issue
Make those all explicit.
Manual Testing Instructions
Test with
install.yamlfor add-ons ddev#6447Automated Testing Overview
Related Issue Link(s)
Release/Deployment Notes