Merged
Conversation
| @@ -11,17 +12,18 @@ export const GITHUB_ISSUES_URL = "https://github.com/ddev/ddev/issues" | |||
| export const DOCUMENTATION_URL = "https://ddev.readthedocs.io/" | |||
| export const DISCORD_URL = "/s/discord" | |||
| export const EMAIL_URL = "mailto:support%40ddev.com" | |||
Collaborator
There was a problem hiding this comment.
This typo to be specific we need to replace %40 for @
Member
Author
There was a problem hiding this comment.
This works in regular links, and the idea is to prevent web crawlers from capturing the email address.
Collaborator
There was a problem hiding this comment.
oooh, that makes sense, I thought this was the original issue with the email on the footer.
Collaborator
the email issue seems to carry the on both places.
It looks like it was a typo on that variable. i added a comment to that.
|
Collaborator
|
other than that the contact page seems fine. |
bmartinez287
approved these changes
Dec 26, 2024
Deploying ddev-com-front-end with
|
| Latest commit: |
75972f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://52f7a161.ddev-com-front-end.pages.dev |
| Branch Preview URL: | https://20241224-contact-and-linkedi.ddev-com-front-end.pages.dev |
stasadev
approved these changes
Dec 26, 2024
Member
stasadev
left a comment
stasadev
left a comment
There was a problem hiding this comment.
I added LinkedIn SVG and fixed this error in the dev console
Looks good to me!
Member
Author
|
You're awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Issue
emailin the footer didn't actually work, at least on my browserRendered at https://20241224-contact-and-linkedi.ddev-com-front-end.pages.dev/
See especially the footer and /contact pages