Skip to content

build: implement stable URLs for forked PR previews#432

Merged
rfay merged 2 commits intoddev:mainfrom
rfay:20250922_rfay_stable_url
Sep 22, 2025
Merged

build: implement stable URLs for forked PR previews#432
rfay merged 2 commits intoddev:mainfrom
rfay:20250922_rfay_stable_url

Conversation

@rfay
Copy link
Member

@rfay rfay commented Sep 22, 2025

The Issue

Thanks as always @stasadev for your careful and thoughtful review and solutions.

How This PR Solves The Issue

  • Migrate from deprecated cloudflare/pages-action to cloudflare/wrangler-action@v3
  • Use pages-deployment-alias-url output for stable branch URLs
  • Update URL pattern matching for broader compatibility
  • Replace "Known Issues" documentation with "Stable URL Implementation"
  • Maintain backward compatibility with existing project configuration

Manual testing

🤖 Generated with Claude Code

rfay and others added 2 commits September 22, 2025 07:03
- Migrate from deprecated cloudflare/pages-action to cloudflare/wrangler-action@v3
- Use pages-deployment-alias-url output for stable branch URLs
- Update URL pattern matching for broader compatibility
- Replace "Known Issues" documentation with "Stable URL Implementation"
- Maintain backward compatibility with existing project configuration

This resolves the URL stability problem where preview URLs changed with each deployment,
providing consistent URLs for better collaboration and bookmarking.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
- Add .github/workflows/ to .prettierignore to exclude workflow files
- Fix formatting in .github/FORK_PREVIEW_SETUP.md per prettier requirements
- Workflows use different YAML formatting conventions than main codebase

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@rfay rfay requested a review from stasadev September 22, 2025 13:20
@github-actions
Copy link

🌐 Fork Preview for PR #432

https://27a5dfec.ddev-com-fork-previews.pages.dev

This preview updates automatically when you push changes to your fork.

Copy link
Member

@stasadev stasadev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me.

@rfay rfay merged commit d4d6f10 into ddev:main Sep 22, 2025
4 checks passed
@github-actions
Copy link

PR closed. The Cloudflare Pages preview is no longer updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants