Merged
Conversation
https://ddi-alliance.atlassian.net/jira/software/c/projects/DDILIFE/issues/DDILIFE-3712 - rename ControlledVocabularyURN to ControlledVocabularyURI - explicitly mention SKOS and XKOS in documentation - add ControlledVocabularyInstanceURI - restructure agency, id, and version attributes as a CodeList reference
DanSmith
requested review from
borsna,
jeremyiverson,
spuddybike and
wlthomas
wlthomas
reviewed
Feb 24, 2025
Collaborator
There was a problem hiding this comment.
These changes look good to me.
jeremyiverson
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #58
TypeOfVersionNumber should be a CodeValueType
https://ddi-alliance.atlassian.net/jira/software/c/projects/DDILIFE/issues/DDILIFE-3714
TypeOfUserID and TypeOfUserVersion should be CodeValueType
https://ddi-alliance.atlassian.net/jira/software/c/projects/DDILIFE/issues/DDILIFE-3694
Allow vocabulary instance URIs in code value
https://ddi-alliance.atlassian.net/jira/software/c/projects/DDILIFE/issues/DDILIFE-3712
-- rename ControlledVocabularyURN to ControlledVocabularyURI
-- explicitly mention SKOS and XKOS in documentation
-- add ControlledVocabularyInstanceURI
-- restructure agency, id, and version attributes as a CodeList reference