Prohibit the use of any javascript in the SVGs #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The CI log output can be troll. I assume because of browsers and githubs anti XSS they may filter things out. But it should still mostly make sense. If not the check has to be run locally.
|
Member
|
Can you rebase. Seems like rerunning jobs doesn't |
Member
Author
i hate this |
Sounds like a security and parsing nightmare, bloating file sizes at best. Also if the svg really depends on javascript to properly work this increases the complexity to render out the images.
ChillerDragon
force-pushed
the
pr_nojs
branch
from
28a75dc to
cd4ff40
Compare
Member
|
No need to hate the user in front of your pc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sounds like a security and parsing nightmare, bloating file sizes at best. Also if the svg really depends on javascript to properly work this increases the complexity to render out the images.