Exclude default ports 80/443 from base URL

[dinoboff]

Fix #59

Breaking changes: the URL is validated

[dinoboff]

I defined the helper as a static method (easier for testing) but I am happy to define it on the prototype like the other helpers if you prefer.

[ddo]

is static method is supported by older nodejs or browser?

[dinoboff]

IE9+, Safari 5+ and evergreen browser support Object.defineProperties. I am guessing every node versions support ES 5.1; node 0.10 certainly supports Object.defineProperties.

If you need better support, I can define it as OAuth.parseUrl = function(url) {...}.

[ddo]

how about prototype?

[ddo]

too many changes. take me time to review all of them, be patient

[ddo]

this PR only "Exclude default ports 80/443 from base URL"? why take 13 files changes

[dinoboff]

@ddo Rebased on master

[dinoboff]

@ddo

Define parseUrl(url) with the other helpers.

[dinoboff]

That's crud fix. Maybe we should parse the URL without reg. exp. It would avoid any breaking changes.

[ddo]

i still checking the regex part. any source?

[dinoboff]

Based on https://en.wikipedia.org/wiki/URL (although I just notice the password part of the auth should be optional). The host is optional but required for OAuth request:

/^
  (https?):\/\/      # scheme://
  ([^:]+:[^@]+@)?    # [user[:password]@] (to fix)
  ([^:/?#]+)         # host
  (\:\d+)?           # [:port]
  (\/[^?#]*)?        # [/path]
  (\?[^#]*)?         # [?query]
  (#.*)?             # [#fragment] 
$/

[ddo]

i think we do it too complicated for this simple task?

[dinoboff]

Possibly. We don't need to extract the scheme + port and later the query with the same regexp.

[ddo]

i really don't understand this line. does this check http prefix?