Record Idle Time, Add Repo Label & Make config accessible in label_value()#28
Open
ackerdev wants to merge 6 commits intodeadtrickster:masterfrom
Open
Record Idle Time, Add Repo Label & Make config accessible in label_value()#28ackerdev wants to merge 6 commits intodeadtrickster:masterfrom
ackerdev wants to merge 6 commits intodeadtrickster:masterfrom
Conversation
Owner
|
Hi, thank you for this. Please bump version in mix.exs |
Author
|
Done, thank you for taking the time to review & merge! |
Author
|
Also, added some docs updates that will also close #24 |
|
Hi, this MR looks gorgeous! Any chance it can be merged soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the new idle_time metric introduced in ecto_sql 3.3.0, adds repo labeling, and allows config to be accessed in
label_value().Repo label and the config change would be breaking changes.
For some context on the label_value() config change, my usecase is that we have multiple repos across multiple apps within an umbrella application. We want to be able to record both the repo and app so we can split out results in our dashboards appropriately. This change will allow me to do the following:
I tried to split each change into it's own commit if you want to pick-and-choose which changes to accept or review them individually.
Closes #26