Open
Conversation
Owner
|
linux_logo doesn't auto-detect distribution, it's up to the distribution to put an /etc/linux_logo.conf that sets the default logo to use. your patch is using unicode characters. For the ASCII logos they should print properly on a 7-bit ASCII display so you can't use unicode. Unicode might be OK for the color logos, though it's preferable not to. You can generate a colored box by using a space with a background color set, but that might only let you have darker colors on most terminals. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
Please add support for the Manjaro logo. I could not figure out how you auto-detect the logo so this pull request only has the logos in it. Sorry, my C is really rusty!
Thanks for this software, I like it! No dependencies, straight to the point, great! :-)
Logo:
Banner: