Skip to content

Bump react and react-dom to v19#2573

Closed
ebroder wants to merge 1 commit intomainfrom
evan/bump-react
Closed

Bump react and react-dom to v19#2573
ebroder wants to merge 1 commit intomainfrom
evan/bump-react

Conversation

@ebroder
Copy link
Member

@ebroder ebroder commented Dec 8, 2025

I think that the reason Dependabot's upgrade didn't work is because it only upgraded react without also upgrading react-dom, so add a rule to upgrade both at the same time in the future.

Supersedes #2562

I think that the reason Dependabot's upgrade didn't work is because it
only upgraded react without also upgrading react-dom, so add a rule to
upgrade both at the same time in the future.
@ebroder ebroder requested a review from zarvox December 8, 2025 01:40
@ebroder
Copy link
Member Author

ebroder commented Dec 8, 2025

Meh I can fix most of the type errors, but slate-react needs updating for React 19:

node_modules/slate-react/dist/components/text.d.ts:8:59 - error TS2503: Cannot find namespace 'JSX'.

8     renderPlaceholder: (props: RenderPlaceholderProps) => JSX.Element;
                                                            ~~~

node_modules/slate-react/dist/components/text.d.ts:9:47 - error TS2503: Cannot find namespace 'JSX'.

9     renderLeaf?: ((props: RenderLeafProps) => JSX.Element) | undefined;
                                                ~~~

node_modules/slate-react/dist/components/text.d.ts:10:47 - error TS2503: Cannot find namespace 'JSX'.

10     renderText?: ((props: RenderTextProps) => JSX.Element) | undefined;
                                                 ~~~

so I think this is stuck for the moment.

@ebroder ebroder closed this Dec 8, 2025
@ebroder ebroder deleted the evan/bump-react branch December 17, 2025 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant