Conversation
React 19 changed how refs behave. These changes make our code compatible with both the behavior in v18 and v19.
zarvox
approved these changes
Dec 10, 2025
Contributor
zarvox
left a comment
zarvox
left a comment
There was a problem hiding this comment.
Looks like just typing changes, that allow being more precise/narrow with the actual types of the RefObjects? Sounds great.
Member
Author
|
Yeah. We'll eventually want to switch everything to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React 19 changed how refs behave. These changes make our code compatible with both the behavior in v18 and v19.
(I think we should theoretically be able to auto-upgrade to React 19 once this + #2575 + ianstormtaylor/slate#5986 land, although it's separately worth taking advantage of some of the new features in v19, like ref-as-prop, the new
useActionStatehook, and potentially the newuseAPI for suspending while promises are resolving)