Skip to content

clean up tests for refactoring #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tonyfast wants to merge 2 commits into
base: main
Choose a base branch
from
Open

clean up tests for refactoring #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85f3b18
rm silly tests that create static files now that everything is embedd…
tonyfast Dec 8, 2023
db188a6
Merge branch 'main' into clean-up-tests
tonyfast Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions tests/test_smoke.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,29 +66,6 @@ def get_target_html(config, notebook):
)


assets = mark.parametrize("asset", ["settings.js", "style.css"])


@configs
def test_config_loading(config):
"""Verify configs are loaded."""
exporter_from_config(config) # will ExporterNameError if there is a failure.


@assets
def test_static_assets(asset):
"""This is a bad test. it won't fail, but needs to run to collect testing assets."""
target = HTML / asset
target.parent.mkdir(exist_ok=True, parents=True)
for path in map(
Path, jupyter_core.paths.jupyter_path("nbconvert", "templates", "a11y", "static", asset)
):
if path.exists():
copyfile(path, target)
break
assert target.exists(), f"{asset} couldn't be created"


@configs
@notebooks
def test_export_notebooks(config, notebook):
Expand Down