Open
Conversation
Open
Member
jakubmanczak
left a comment
jakubmanczak
left a comment
There was a problem hiding this comment.
Partial; will return to this in the evening.
jakubmanczak
requested changes
Oct 27, 2025
Member
|
It would be nice not to implement Display and FromStr for unit enums by hand. The strum crate does this for us, but this can definitely be done in a future pull request as it will require integration of strum errors into OmniError. |
Member
|
Also; does your autoformatting work? When testing this PR locally a lot of changes are made on save. That's not supposed to happen. |
Member
|
Merging master into this branch is also in order. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #47. Builds up on #46 and #49.