Add coordinate-based screen switching and grave modifier support #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements support for using the grave key (`) as a hotkey modifier in Barrier, enabling hotkey combinations like Grave+1, Grave+2, etc. Key changes: - Add XK_grave case to getModifierBitForKeySym() for XKB support - Add fallback mapping for grave modifier to Mod4 in XKB path - Include KeyModifierGrave in allowed modifiers for hotkey registration - Add setup documentation for required X11 modifier mapping Requires running: xmodmap -e "add mod4 = grave" 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add missing grave key definitions in KeySequence class - Improve key type mapping for grave modifier - Ensure consistent grave modifier behavior across GUI and core 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add coordinate-based screen switching and grave modifier support
|
Please open this PR in Deskflow or Input Leap as Barrier is no longer in development. https://github.com/deskflow/deskflow Both are compatible with Barrier client/server so you can try on one of your computers. Not sure which project to contribute to? The 'Insights' tab of each project may help you decide. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds two major features to Barrier:
🎯 Coordinate-Based Screen Switching
switchToScreenaction to accept optional coordinates:switchToScreen(screen,x,y)switchToScreen(screen)syntax still works⌨️ Grave Modifier Support
keystroke(Grave+1) = switchToScreen(screen1,960,540)🔧 Compilation Improvements
#include <cstdint>headers for C++17+ compilersKey Implementation Details
Coordinate Switching:
SwitchToScreenActionconstructor accepting x,y coordinatesswitchScreen()integration for precise positioningGrave Modifier:
KeyModifierGraveconstant (0x0080) and bit (7)GraveModifierconstantBackward Compatibility
✅ All existing configurations continue to work unchanged
✅ No breaking changes to API or config format
✅ Default behavior preserved when coordinates not specified
Test Results
Documentation
GRAVE_MODIFIER_SETUP.mdwith setup instructionsCOMPILATION_GUIDE.mdwith detailed build stepsThis enhancement significantly improves Barrier's usability for complex multi-monitor setups and provides additional hotkey modifier options.
🤖 Generated with Claude Code