feat: add default value processing to ibmi#84
feat: add default value processing to ibmi#84tomsharpjhc wants to merge 1 commit intodebezium:mainfrom
Conversation
|
❌ Developer Certificate of Origin (DCO) check failed. Hi @tomsharpjhc, please sign off all commits with: If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes. |
|
Hi @tomsharpjhc, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key. |
|
Hi @tomsharpjhc please log an issue at https://github.com/debezium/dbz and prefix your commits with the issue number, e.g. |
| case Types.TIMESTAMP_WITH_TIMEZONE: | ||
| throw new UnsupportedOperationException("not yet implemented to default to timestamp and timezone, value was: " + value); |
There was a problem hiding this comment.
Is there a reason why this was removed rather than being implemented?
| } | ||
| switch (column.jdbcType()) { | ||
| case Types.DATE: { | ||
| if ("CURRENT_DATE".equals(value)) { |
There was a problem hiding this comment.
Instead of removing this and other sspecial cases It should be kept but the default value should be set to epoch.
It will avoid unnecessary warnings and at the same time the behaviour will be consistent with other connectors.
3 participants
At present, the system ignores default values from the messaging.
I think it would be preferable to pass on the default where provided. Also tidy up some of the processing for converting default values.