debezium/dbz#1245 Add description field to connections API payload#309
Open
PDGGK wants to merge 1 commit intodebezium:mainfrom
Open
debezium/dbz#1245 Add description field to connections API payload#309PDGGK wants to merge 1 commit intodebezium:mainfrom
PDGGK wants to merge 1 commit intodebezium:mainfrom
Conversation
2231332 to
61590be
Compare
|
Hi @PDGGK, thanks for your contribution. Please prefix the commit message(s) with the debezium/dbz#xxx GitHub issue key. |
Member
|
@PDGGK Thanks for you first PR! Could you please sign-off you commits and format with debezium/dbz#xxx GitHub? |
62dff95 to
0dfb2ff
Compare
Member
|
Hi @PDGGK your email addresses do not match on the commit sign-offs with what is expected, see |
Signed-off-by: Zihan Dai <99155080+PDGGK@users.noreply.github.com>
0dfb2ff to
43ffedc
Compare
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
descriptionfield to the connections API payload, consistent with all other resources (pipelines, sources, destinations, transforms, vaults) that already have this field.Closes debezium/dbz#1245
Changes
Backend (Java/Quarkus):
ConnectionEntity.java: Addeddescriptionfield with getter/setterConnection.java(Blaze-Persistence EntityView): AddedgetDescription()/setDescription()V3.5.0__add_connection_description.sql: Addsdescription varchar(255)column toconnectiontableFrontend (TypeScript/React):
apis.tsx: Addeddescription?: stringtoConnectionandConnectionPayloadtypesConnections.json: Updated mock data with description fieldTests:
ConnectionResourceIT.java: Updated test payloads to include description, added assertions, addedtestCreateConnection_WithoutDescriptionto verify optionalityDesign Decisions
varchar(255)matches existing description columns in other tables