-
-
Notifications
You must be signed in to change notification settings - Fork 12
debezium/dbz#1499 Do not return invalidDateAndTimeRepresentation when year 0000 #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debezium/dbz#1499 Do not return invalidDateAndTimeRepresentation when year 0000 #15
Conversation
.github/workflows/mysql-80.yml
Outdated
| - uses: ./.github/actions/setup-java | ||
| - name: Cache Maven packages | ||
| uses: actions/cache@v1 | ||
| uses: actions/cache@v4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this is not related to the MySQL issue, let's remove this and apply this in a separate PR, please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense - removed and the separate PR is here: #18
|
Please raise an issue in https://github.com/debezium/dbz and prefix your commit with |
|
❌ Developer Certificate of Origin (DCO) check failed. Hi @adelajaworowska, please sign off all commits with: If pull request commits are not signed off, the pull request cannot be merged. For more information about why this is required, please see our blog about contribution requirement changes. |
Signed-off-by: Adela Jaworowska-Nowak <[email protected]>
1040cdf to
6e0355f
Compare
|
Thank you @Naros for your comments. I applied changes and created the issue as you asked. |
jpechane
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adelajaworowska LGTM, thanks. Could you please add sign-off to the commit (see DCO requirement) and undraft the PR? I'll merge it then.
|
@jpechane thank you for the approval. I undrafted the PR and I the commit is signed-off. Please proceed with merging |
|
@jpechane I see two build failures:
|
|
@adelajaworowska I tested the fix on MySQL 8 locally. If you'd have spare cycles and by able to rewrite |
|
@jpechane thank you! |
|
I intend to merge #17 on Monday (this will require changes in Debezium too) and then I'll do release right away. |
Fixes debezium/dbz#1499
MySQL allows the storage of 'zero-year' dates such as 0000-07-15. Currently, the library throws an invalidDateAndTimeRepresentation exception when encountering these values.
I would like the library to support these dates by converting them to a Unix timestamp (epoch-based) instead of failing.