debezium/dbz#1518 fix EventDeserializer composition #19
+89
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adela Jaworowska-Nowak <[email protected]>
|
@adelajaworowska Unfortunately as you are aware the CI is now broken so I'd be glad if you could run the tests locally and let me know if they passes when the PR is ready for review. Thanks for understanding. |
sfc-gh-mmultarzynski
suggested changes
Jan 13, 2026
| new MariadbGtidListEventDataDeserializer()); | ||
| eventDataDeserializers.put(EventType.TRANSACTION_PAYLOAD, | ||
| new TransactionPayloadEventDataDeserializer()); | ||
| new TransactionPayloadEventDataDeserializer(this)); |
There was a problem hiding this comment.
What about other deserializers? Does only TransactionPayloadEventDataDeserializer needs to have this parameters?
| public static final int OTW_PAYLOAD_COMPRESSION_TYPE_FIELD = 2; | ||
| public static final int OTW_PAYLOAD_UNCOMPRESSED_SIZE_FIELD = 3; | ||
|
|
||
| private final EventDeserializer parentEventDeserializer; |
There was a problem hiding this comment.
Will this cause cyclic reference?
Signed-off-by: Adela Jaworowska-Nowak <[email protected]>
adelajaworowska
force-pushed
the
eventDeserializer-composition-fix
branch
from
9c922e6 to
99a612e
Compare
Signed-off-by: Adela Jaworowska-Nowak <[email protected]>
Signed-off-by: Adela Jaworowska-Nowak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes debezium/dbz#1518
When compatibility mode is set TransactionPayloadEventDataDeserializer() should be aware about it and in deserialize method when it creates new deserializer
EventDeserializer transactionPayloadEventDeserializer = new EventDeserializer(); it should set compatibility mode from top level object.FYI, the issue was also raised in osheroff repo: osheroff#127, osheroff#138 but never addressed.