Simple workaround for scanning scala projects #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@biswajit-patra-dev please remove the CodeScene workflow 😊 so pipeline will pass |
Collaborator
Author
|
@sweoggy I have removed the CodeScene workflow as suggested. |
sweoggy
reviewed
Apr 1, 2025
sweoggy
reviewed
Apr 2, 2025
sweoggy
reviewed
Apr 2, 2025
sweoggy
reviewed
Apr 2, 2025
sweoggy
reviewed
Apr 2, 2025
sweoggy
reviewed
Apr 2, 2025
sweoggy
reviewed
Apr 2, 2025
sweoggy
approved these changes
Apr 2, 2025
Contributor
sweoggy
left a comment
sweoggy
left a comment
There was a problem hiding this comment.
The Dockerfile changes look good and the general idea of this PR 👍
I have not tested nor reviewed the functionality of the Go code, I will let someone else with more experience review those parts
Collaborator
Author
|
Here is the test scan result. |
biswajit-patra-dev
requested review from
ProgHaj
and removed request for
ProgHaj
ProgHaj
reviewed
Apr 3, 2025
biswajit-patra-dev
force-pushed
the
scanning-scala-projects
branch
3 times, most recently
from
3a985b2 to
182966c
Compare
ProgHaj
force-pushed
the
scanning-scala-projects
branch
from
2963126 to
6fdeb83
Compare
Contributor
|
Lgtm! |
ProgHaj
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support sbt package support.
build.sbtfile to identify any modulessbt makePomin the project directory to generate a POM file.pomfile (typically intarget/scala-<version>/<project>-<version>.pom).pomfile topom.xmlin the same directory asbuild.sbtpom.xmlfile