fix(#7375): fix dependency issues #7394
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add mapping since jest doesn't understand import maps
martinjagodic
previously approved these changes
Feb 6, 2025
Contributor
Author
|
Update: The PR now also addresses the CSS issue by using babel-plugin-inline-import to inline the CSS. |
Contributor
Author
|
Update: I noticed that the ESM code generated by babel contains a lot of unnecessary transforms that are not required in an ESM environment. I therefore updated the babel config to only use the non-standard plugins. |
|
Hey @martinjagodic - could you please re-review this PR? 🙏🙏🙏 |
martinjagodic
approved these changes
Jun 13, 2025
|
thank-you @martinjagodic, really appreciate it!! 🙏🙏🙏 |
martinjagodic
added a commit
to hip3r/decap-cms
that referenced
this pull request
Jun 13, 2025
* fix: make slate-hyperscript a runtime dependency * fix: bump clean-stack dependency * fix: bump react-scroll-sync dependency * chore: update lock file * fix: workaround for jest add mapping since jest doesn't understand import maps * fix: use babel-plugin-inline-import to inline css in esm build * chore: don't use preset-env for esm build --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
martinjagodic
added a commit
to hip3r/decap-cms
that referenced
this pull request
Jun 13, 2025
* fix: make slate-hyperscript a runtime dependency * fix: bump clean-stack dependency * fix: bump react-scroll-sync dependency * chore: update lock file * fix: workaround for jest add mapping since jest doesn't understand import maps * fix: use babel-plugin-inline-import to inline css in esm build * chore: don't use preset-env for esm build --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
martinjagodic
added a commit
to hip3r/decap-cms
that referenced
this pull request
Jun 13, 2025
* fix: make slate-hyperscript a runtime dependency * fix: bump clean-stack dependency * fix: bump react-scroll-sync dependency * chore: update lock file * fix: workaround for jest add mapping since jest doesn't understand import maps * fix: use babel-plugin-inline-import to inline css in esm build * chore: don't use preset-env for esm build --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
martinjagodic
added a commit
to hip3r/decap-cms
that referenced
this pull request
Jun 13, 2025
* fix: make slate-hyperscript a runtime dependency * fix: bump clean-stack dependency * fix: bump react-scroll-sync dependency * chore: update lock file * fix: workaround for jest add mapping since jest doesn't understand import maps * fix: use babel-plugin-inline-import to inline css in esm build * chore: don't use preset-env for esm build --------- Co-authored-by: Martin Jagodic <jagodicmartin1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses several dependency-related issues identified in #7375:
slate-hyperscriptfrom a dev dependency into a runtime dependency ofdecap-cms-widget-markdownclean-stackto v5.2.0 indecap-cms-corereact-scroll-syncto v0.11.2 indecap-cms-coreThis PR does not address the CSS import issue. Simply removing the imports would break the pre-build scripts, where these imports are resolved by webpack.
Test plan
Verified that the following issues are resolved:
slate-hyperscriptresolution errorclean-stackbrowser compatibility error (os is not defined)react-scroll-syncChecklist
A picture of a cute animal
🐼