feat(ci): add npm package integrity test before publish #7703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a test script that verifies built packages before publishing to npm: - Checks that npm pack works for main packages - Scans dist files for browser-incompatible 'node:' imports - Validates package.json has required fields and entries exist This test runs in both the CI workflow (on PRs) and the publish workflow (before releasing to npm), catching issues like the clean-stack 5.3.0+ browser incompatibility (decaporg#7616) before they reach users. Closes decaporg#7623
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7623 - Add e2e test that checks the integrity of the final npm package prior to pushing to the registry
Adds automated package integrity testing to catch issues before they reach npm users.
What This PR Adds
New test script:
scripts/test-package-integrity.mjsnpm packworks for main packagesnode:importsCI Integration:
nodejs.yml- runs on every PR after buildpublish.yml- runs before publishing to npmWhy This Matters
Recent issues like #7616 (clean-stack browser incompatibility) could have been caught before release if we had integrity testing. This test specifically checks for:
node:protocol imports that break webpack/ViteFiles Changed
scripts/test-package-integrity.mjs- New test scriptpackage.json- Addedtest:package-integrityscript.github/workflows/nodejs.yml- Run test on PRs.github/workflows/publish.yml- Run test before publishTest Plan
npm run test:package-integritylocally after buildingGenerated with Claude Code