fix: Improve UX when minting more than 50 NFTs in a single transaction#3366
Open
JiwaniZakir wants to merge 1 commit intodecentraland:masterfrom
Open
fix: Improve UX when minting more than 50 NFTs in a single transaction#3366JiwaniZakir wants to merge 1 commit intodecentraland:masterfrom
JiwaniZakir wants to merge 1 commit intodecentraland:masterfrom
Conversation
|
@JiwaniZakir is attempting to deploy a commit to the Decentraland Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3365
Previously, users could configure mints exceeding
MAX_NFTS_PER_MINTinMintItemsModaland attempt to submit the transaction, only receiving an error after the fact. The modal had no pre-submission validation against the per-transaction mint limit.MintItemsModal.tsxnow computesexceedsLimitby comparingtotalMintsagainstMAX_NFTS_PER_MINTafter the reduce, disables the submit button viaisDisabled, and surfaces a localized warning viat('mint_items_modal.limit_reached')in the existing error row before the user attempts submission. Verified by manually entering mint amounts exceeding 50 and confirming the button disables and the error message renders inline.