Skip to content

fix: send video hash for all statuses on modifyItem#3371

Open
kevindecibe wants to merge 1 commit intomasterfrom
fix/edit-wearable
Open

fix: send video hash for all statuses on modifyItem#3371
kevindecibe wants to merge 1 commit intomasterfrom
fix/edit-wearable

Conversation

@kevindecibe
Copy link

@kevindecibe kevindecibe commented Mar 23, 2026

Summary

  • Fix smart wearable items showing permanently UNSYNCED after converting a published regular wearable to a smart wearable
  • The item.video field was not being updated in modifyItem when the item had status SYNCED or UNSYNCED, because the assignment was gated behind a condition that only allowed UNPUBLISHED or UNDER_REVIEW statuses
  • This caused item.video to remain undefined (inherited from the original non-smart wearable) while item.contents['video.mp4'] had the correct hash, making isWearableSynced always return false
  • Removed the status check so item.video is always set when the item is a smart wearable with a video in its contents, matching the behavior of createItem

@vercel
Copy link

vercel bot commented Mar 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
builder Ready Ready Preview, Comment Mar 23, 2026 1:27pm

Request Review

@coveralls
Copy link

Pull Request Test Coverage Report for Build 23439575037

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 48.29%

Totals Coverage Status
Change from base Build 23287840377: 0.0%
Covered Lines: 6303
Relevant Lines: 11698

💛 - Coveralls

@kevindecibe kevindecibe self-assigned this Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants