chore: Add check local packages action by cyaiox · Pull Request #1092 · decentraland/js-sdk-toolchain

cyaiox · 2025-04-02T22:51:00Z

This PR adds a new GitHub Action to check for local or development dependencies without canceling artifact generation.

Changes included:

Introduced a new workflow step to detect file:, http:, git:-style dependencies in published packages.
Extracted and migrated the checkNoLocalPackages logic from prepare.spec.ts into a reusable script: .github/scripts/check-no-local-packages.cjs
This script is now used directly in CI to block merges with local dependency references.

Why?

This ensures that:

CI artifacts are always generated (even if dependency checks fail)
Local or dev dependencies do not accidentally make it into published builds
We can reuse the check script independently in both tests and automation pipelines

cloudflare-workers-and-pages · 2025-04-02T22:54:25Z

Deploying js-sdk-toolchain with Cloudflare Pages

Latest commit:	`d858ae5`
Status:	✅ Deploy successful!
Preview URL:	https://70533bd3.js-sdk-toolchain.pages.dev
Branch Preview URL:	https://chore-update-asset-packs.js-sdk-toolchain.pages.dev

View logs

github-actions · 2025-04-02T23:03:10Z

Test this pull request

The @dcl/sdk package can be tested in scenes by running

npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/update-asset-packs/dcl-sdk-7.8.3-14382561212.commit-5ed20a3.tgz"

To test with npx init

export SDK_COMMANDS="https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/update-asset-packs/dcl-sdk-commands-7.8.3-14382561212.commit-5ed20a3.tgz"
npx $SDK_COMMANDS init

The @dcl/inspector package can be tested by visiting this url

Or by installing it via NPM

npm install "https://sdk-team-cdn.decentraland.org/@dcl/js-sdk-toolchain/branch/chore/update-asset-packs/@dcl/inspector/dcl-inspector-7.8.3-14382561212.commit-5ed20a3.tgz"

The /changerealm command to test test in-world

/changerealm https://sdk-team-cdn.decentraland.org/ipfs/chore/update-asset-packs-e2e

You can preview this build entering:
https://playground.decentraland.org/?sdk-branch=chore/update-asset-packs

github-actions · 2025-04-03T00:02:47Z

⚠️ Local Dependencies Detected

This PR contains package dependencies that use local paths (file:) or non-allowed URLs (http:, https:, git:).
These must be published and referenced properly before merging.

Not allowed dependencies:

- Dependency @dcl/asset-packs is not pointing to a published version: https://sdk-team-cdn.decentraland.org/@dcl/asset-packs/branch/fix/show-text-action/dcl-asset-packs-2.2.2-14231447147.commit-ce0144f.tgz

Review the workflow logs for more details.

Note: This comment is automatically updated when the PR is updated.

* update left/right click button behaviour on renderer (#1078) * update left/right click button behaviour on renderer * remove gizmo right click button * fixed review comments * remove desktop client (OLD) option (#1083) * select "Scene" in tree on startup (#1082) * update left/right click button behaviour on renderer * select 'Scene' in tree on startup * add refresh button for Assets (#1085) * support border in uitransforms (#1084) * support border in uitransforms * fix build * change protocol to experimental * use main protocol * fix snapshots test * fix tests * fix coverage * update protocol * export useEffect & useState (#1089) * export useEffect & useState * fix tests * fix: Animation weight value (#1090) * fix: Animation weight value * fix: Animation weight and speed default value * revert .vscode/settings.json * lint * update .crdt * fix models removal when using filters (#1088) * add video player to syncEntities (#1097) * add skip-auth-screen & landscape-terrain-enabled options for preview (#1096) * chore: Add check local packages action (#1092) * chore: Update asset-packs package * fix: Allow dev package * chore: Move check no local packages to a GHAction * chore: Update asset-packs package * fix: Convert TS file to CJS * fix: GHAction comment id * chore: Move local dependencies check to ci pipeline * fix: debug downloaded files * chore: Enhance message * chore: simplify comment dependencies logic * chore: Generate comment.md to properly show in the PR * fix: string comment * fix: error detection * fix: check exit code * fix: catch exit code * chore: Update @dcl/asset-packs * remove AudioSource component from not sync list (#1099) * add entity highlight when selected (#1103) * fix: Handle components schemas errors (#1098) * fix: Basic view TweenComponent to better handle empty entities * fix: Sync external changes * feat: Add Default Basic View Field * fix: Add SyncComponents to Smart Items when using the AdminTools (#1100) * chore: Update @dcl/asset-packs package * fix: Update createEnumEntityId * feat: Add new util addSyncComponentsToEntities to add the Synccomponent and Network component to multiple entities * fix: Tests * chore: Update @dcl/asset-packs package * fix: Remove components for actions that doesn't create components on the fly * fix: Add a validation to avoid include Tween and Transform in the SyncComponent at the same time * chore: Update @dcl/asset-packs * update @dcl/asset-packs@2.3.1 (#1106) * feat: add type safe entity names file (#1107) * feat: add type safe entity names file * fix build: * simplify enum types * update tests * fix bad merge issue with onChange * feat: change shortcut for rotating camera (#1110) Co-authored-by: Alejandra Levy <alejandralevy@Alejandras-MacBook-Pro.local> * fix Texture being flipped vertically (#1111) * add video screen (#1105) * add video screen * update asset-packs package * update ui * update asset-packs * update asset-packs * fix ui styles * fix volume and losing focus * update assert-packs * bump asset-packs * feat: add search param to actions dropdown (#1113) * feat: add search param to actions dropdown * feat: add searchable in Trigger Action and Trigger Basic View * feat: show selected entity first on dropdown (#1112) * feat: show selected entity first on dropdown * feat: remove unused import and reorder import * Update packages/@dcl/inspector/src/components/ui/EntityField/EntityField.tsx Co-authored-by: Gabriel Díaz <git@subsme.slmail.me> Signed-off-by: Alejandra Levy <alelevy15@gmail.com> * feat: update method --------- Signed-off-by: Alejandra Levy <alelevy15@gmail.com> Co-authored-by: Gabriel Díaz <git@subsme.slmail.me> * Support jpg textures (#1114) * feat: support jpg & jpge textures * feat: support jpg and jpeg for all images inputs * feat: update validation for textures * feat: Update regez to support .jpg and .jpge extensions * feat: fix lint issues * feat: add validation on input change * feat: change regex to pass tests * feat: update validation on component * feat: add error message for invalid URL and stop validating empty field * feat: update message * Update global value on Audio Source component (#1119) * feat: update global value & validate source input only where there's a value * feat: remove debugger * Support global prop on play sound action (#1120) * feat: support global prop on play sound action * feat: update pacjkage json * feat: update package json and fix issues * feat: install asset packs version * feat: update asset pack version * feat: install asset packs version on inspector * feat: remove asset packs from root package.json * feat: update package-lock * fix enter scene callback not being fired if there is no onLeaveCb (#1124) * fix enter scene callback not being fired if there is no onLeaveCb * fix tests and update asset-packs * feat: cursor position info (#1123) * Updated protocol and added test for the new PrimaryPointerInfo component * Lint-fix pass * fix play video not updaing src property (#1129) * add default emotes (#1132) * feat: 4088 add z-index support for ui elements (#1127) * Updated protocol pointers to dev branch * Added zIndex to the react-ecs component and test (cherry picked from commit 7ea5cfd) * Added opacity property to ui elements * Fixed tests * Updated protocol * Updated snapshots * Removed redundant definitions. Added test coverage * Adjusted the default value in test * ui transform test wip * Added more tests. Refactored parseUiTransform utility function to properly handle the new properties * Deep clean and snapshot * Removed redundant tests, removed redundant defaults definitions. * Updated snapshots * Updated default value for opacity and updated snapshots * feat: Update asset packs package (#1135) * update protocol from protocol-squad branch add "make update-protocol-squad" * fixes and update crdt snapshots * reduce coverage to 90% for protocol-squad branch * update protocol (add setUiFocus) --------- Signed-off-by: Alejandra Levy <alelevy15@gmail.com> Co-authored-by: Nicolas Echezarreta <nicoecheza@gmail.com> Co-authored-by: Gon Pombo <gonzalo@decentraland.org> Co-authored-by: Gabriel Díaz <git@subsme.slmail.me> Co-authored-by: Alejandra Levy <alelevy15@gmail.com> Co-authored-by: Alejandra Levy <alejandralevy@Alejandras-MacBook-Pro.local> Co-authored-by: Alejandro Alvarez Melucci <163010988+AlejandroAlvarezMelucciDCL@users.noreply.github.com>

decentraland deleted a comment from github-actions bot Apr 2, 2025

cyaiox force-pushed the chore/update-asset-packs branch from e8389ae to eee7b49 Compare April 3, 2025 00:00

cyaiox force-pushed the chore/update-asset-packs branch 4 times, most recently from 386c4d3 to cc59998 Compare April 4, 2025 19:25

cyaiox changed the title ~~chore: Update asset-packs package~~ chore: Add check local packages action Apr 4, 2025

cyaiox mentioned this pull request Apr 10, 2025

Enhance the check local packages flow decentraland/sdk#1179

Open

cyaiox added 15 commits April 10, 2025 11:06

chore: Update asset-packs package

729889b

fix: Allow dev package

c566433

chore: Move check no local packages to a GHAction

98a8020

chore: Update asset-packs package

3b18e55

fix: Convert TS file to CJS

51ebaf8

fix: GHAction comment id

b7d9f77

chore: Move local dependencies check to ci pipeline

35e3104

fix: debug downloaded files

626392a

chore: Enhance message

9d3c1a6

chore: simplify comment dependencies logic

b997aed

chore: Generate comment.md to properly show in the PR

c4b7300

fix: string comment

dad64c3

fix: error detection

7f2e93b

fix: check exit code

129df2d

fix: catch exit code

7708d29

cyaiox force-pushed the chore/update-asset-packs branch from bae129c to b7fa352 Compare April 10, 2025 14:07

chore: Update @dcl/asset-packs

d858ae5

cyaiox force-pushed the chore/update-asset-packs branch from b7fa352 to d858ae5 Compare April 10, 2025 14:07

nicoecheza approved these changes Apr 10, 2025

View reviewed changes

cyaiox merged commit 65369cd into main Apr 10, 2025
9 checks passed

cyaiox deleted the chore/update-asset-packs branch April 10, 2025 17:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Add check local packages action#1092

chore: Add check local packages action#1092
cyaiox merged 16 commits intomainfrom
chore/update-asset-packs

cyaiox commented Apr 2, 2025 •

edited

Loading

Uh oh!

cloudflare-workers-and-pages bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 2, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Apr 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

cyaiox commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes included:

Why?

Uh oh!

cloudflare-workers-and-pages bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Deploying js-sdk-toolchain with Cloudflare Pages

Uh oh!

github-actions bot commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test this pull request

Uh oh!

github-actions bot commented Apr 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ Local Dependencies Detected

Not allowed dependencies:

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

cyaiox commented Apr 2, 2025 •

edited

Loading

cloudflare-workers-and-pages bot commented Apr 2, 2025 •

edited

Loading

github-actions bot commented Apr 2, 2025 •

edited

Loading

github-actions bot commented Apr 3, 2025 •

edited

Loading