feat: add ranking update endpoint for places#791
Merged
AndresMorelos merged 8 commits intomasterfrom Feb 5, 2026
Merged
Conversation
- Introduced a new API endpoint `/places/{place_id}/ranking` to update the ranking score of a place, requiring service token authentication.
- Updated OpenAPI documentation to include details about the new endpoint, its authentication requirements, and use cases.
- Added corresponding schemas and types for the ranking update request and response.
- Integrated the new ranking update functionality into the existing routes for places.
Pull Request Test Coverage Report for Build 21713120103Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
- Added a new middleware `withServiceAuth` to validate service-to-service authentication using a pre-configured token. - Refactored the `updateRanking` endpoint to utilize the new middleware for authentication. - Created unit tests for the middleware to ensure proper validation of authorization tokens and error handling.
kevinszuchet
reviewed
Feb 4, 2026
src/middleware/withServiceAuth.ts
Outdated
| @@ -0,0 +1,82 @@ | |||
| import Context from "decentraland-gatsby/dist/entities/Route/wkc/context/Context" | |||
Contributor
There was a problem hiding this comment.
I didn't know that we already had this one https://github.com/decentraland/decentraland-gatsby/blob/master/src/entities/Auth/routes/withBearerToken.ts
Would you mind using it? 🙏
…dd-ranking-endpoint' into feat/re-discovery-add-ranking-endpoint
- Changed error messages for missing or invalid authorization tokens to be more descriptive. - Replaced the `withServiceAuth` middleware with `withBearerToken` for improved token validation. - Removed outdated tests related to the previous authorization method.
- Modified the `withBearerToken` call to include an `optional: false` parameter, ensuring that the token is required for authorization.
- Replaced destructured AbortController usage with a direct instance to enhance clarity. - Updated the abort logic to use the controller instance for better readability and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/places/{place_id}/rankingto update the ranking score of a place, requiring service token authentication.