fix: Update SDK version handling in API and documentation to treat null SDK values as SDK6 (legacy scenes)#797
Merged
AndresMorelos merged 8 commits intomasterfrom Feb 26, 2026
Conversation
…ll SDK values as SDK6 (legacy scenes)
Pull Request Test Coverage Report for Build 22353561345Details
💛 - Coveralls |
…ersion filtering in API and documentation
…dk-null-are-treated-as-v6
LautaroPetaccio
approved these changes
Feb 23, 2026
Contributor
LautaroPetaccio
left a comment
LautaroPetaccio
left a comment
There was a problem hiding this comment.
LGTM 👍 Great job!
package.json
Outdated
Comment on lines
+119
to
+121
| "populate:sdk:dev": "DOTENV_CONFIG_PATH=.env.development ts-node -r dotenv/config bin/populateSdk.ts", | ||
| "populate:sdk:stg": "DOTENV_CONFIG_PATH=.env.stg ts-node -r dotenv/config bin/populateSdk.ts", | ||
| "populate:sdk:prd": "DOTENV_CONFIG_PATH=.env.prd ts-node -r dotenv/config bin/populateSdk.ts", |
Contributor
There was a problem hiding this comment.
Would you mind removing the scripts from the package.json?
src/entities/Place/model.test.ts
Outdated
| ) | ||
| }) | ||
|
|
||
| test(`should count places with SDK=6 filter with prefix matching and include null SDK values`, async () => { |
Contributor
There was a problem hiding this comment.
WDYT about, instead of adding these test that unit test the queries, we add integration tests for the endpoints that use this filter? We're testing it in the destination integration tests, but we could have others for the places one.
Comment on lines
+115
to
+116
| const contentUrl = `${worldsContentServerUrl}/contents/${entityId}` | ||
| const contentResponse = await fetch(contentUrl) |
Contributor
There was a problem hiding this comment.
By fetching here the entity, we would check if the runtimeVersion is already there to save some time and not fetch the scene.json if it is. Themetadata.runtimeVersion could have the SDK version.
…ching places with SDK filtering
…dk-null-are-treated-as-v6
…dk-null-are-treated-as-v6
AndresMorelos
deleted the
feat/re-discovery-places-and-worlds-with-sdk-null-are-treated-as-v6
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.