Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this PR change?
What it DOESNT change should I say?
This PR handles a deep wound on our pride which was the complexity introduced by the SharedSpaceManager. After the refactor of the chat it became obvious that the next step was removing this dependency that caused so much pain when adding any new panel to the sidebar or any logic related to the chat in general.
I also took the opportunity to fix many warnings in the files I edited, as we discussed in dev meetings, reducing the warnings amount and sticking to the code style was a yes even if it didnt relate directly to our PR.
The main change is obviously, the removal of all logic on the
SharedSpaceManager, to do this, I converted every sidebar panel into POPUPs views. Why? because they should be, they are managed just using the MVC Manager and its predictably and easy to follow.This meant adding controllers to many views that didn't have them and making sure their initialization and disposal was cleanly done instead of the mishmash of things we had there.
I also streamlined how the sidebar icons get selected/deselected, using specifically the awaiter of the mvcManager to know when the view was closed. This made it SO easy to track.
The only exception to these changes is the Friends Panel which became a FULLSCREEN view. Why? because it needs to hide the Chat and ALL Fullscreen views hide the chat. The rest of the logic is the same as before.
Other changes included removing a lot of asmdefs and replacing them by asmrefs pointing to (for now) the Social asmdef, as we are trying to coalesce all UI player facing features into one Assembly Def. This saved me from several circular refs I faced during the long gestation of this feature.
Another big change that was added was a way to close the whole hierarchy of windows to go back to the chat. This meant the creation of a new method in the
MVCManagercalledCloseAllNonPersistentwhich does as it names say, close all non persistent views, including all POPUPs, any FULLSCREEN and OVERLAY that might be open. In this way we return to have only persistent views open and we can then send events to the chat to do magics.The communication with the chat remains now using events which I also streamlined, removing the duplicated buses we had for chatEvents. So for example, we are in a popup on top of the communities browser fullscreen view, when we click on the chat button, we close all views, focus the chat and then open the community conversation.
Other than this, I made a big cleanup of params sent from the DynamicWorldContainer to the plugins, removing most of those that can be accessed through singletons particularly for FeatureFlags.
Test Instructions
This feature introduces changes to how the Chat is opened from any other window, as well as how the Sidebar works.
This means we need to test the following: