chore: add launch counter for Sentry reporting#7554
Open
mikhail-dcl wants to merge 2 commits intodevfrom
Open
Conversation
Contributor
|
Windows and Mac build successful in Unity Cloud! You can find a link to the downloadable artifact below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
has_edentityalone doesn't recognize the first launch, as it will reportfalseon re-login.What does this PR change?
Adds a
LaunchCounterclass to the analytics domain that persists and increments a launch count across application runs viaDCLPlayerPrefs. The count is attached as a tag to the Sentry loading transaction.Key Changes
LaunchCounterstatic class inAssets/DCL/PerformanceAndDiagnostics/Analytics/— reads, increments, and persists the countDCLPrefKeys.LAUNCH_COUNTkey for persistenceLaunchCounter.Increment()called fromAnalyticsContainer.CreateAsyncalongsideCrashDetector.Initializelaunch_counttag added to the loading process Sentry transaction inLoadingStatusAnalyticsDecoratorhas_identityandidentity_expiredtags also included in the same transactionTest Instructions
Test Steps
launch_counttag appears on theloading_processSentry transactionQuality Checklist