Skip to content

Conversation

@swcurran
Copy link
Contributor

@swcurran swcurran commented Feb 6, 2025

Fixes the repeated typo "kid " in the JSON examples in the appendix, as pointed out in #461.

Note that I fixed the active spec, plus the two snapshots (2.0, 2.1), as it is clearly a mistake in all 3 sets of examples. A picky reviewer might want to remove the "snapshot" fixes (and happy to do that), but I think it is kinda silly to keep such an obvious typo in place.

Signed-off-by: Stephen Curran [email protected]

Copy link
Contributor

@FabioPinheiro FabioPinheiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you replace "kid " with a empty string

Signed-off-by: Stephen Curran <[email protected]>
Signed-off-by: Stephen Curran <[email protected]>
@swcurran
Copy link
Contributor Author

Well, that’s embarrassing! Fixed. I think..

Sorry to waste your time @FabioPinheiro , let alone mine...

@FabioPinheiro
Copy link
Contributor

You didn't waste my time I was looking for another thing about relative-did-urls.
I indeed use those examples on my test vector, and already have it fix on my library.

Would be nice with someone merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants