Skip to content

Conversation

@henkvancann
Copy link

Feel free to correct my initial creation of the Q-and-A of Sidetree.

@bumblefudge
Copy link

On today's meeting, Daniel mentioned that we can use the GH CDN to link directly to images already on github to reduce asset creep:

https://rawgit.org/ , for example, turns this the ION logo already in the sidetree repo:
https://github.com/decentralized-identity/sidetree/blob/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png
into this:
https://ghcdn.rawgit.org/decentralized-identity/sidetree/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png
which can be linked from the QnA's

@henkvancann
Copy link
Author

package-lock.json changes seems to be included in this documentation PR.

No idea how that entered my repo, but I've deleted it and synced with (pulled) the main repo to my repo on GitHub and went on from there. Issue should be solved.

@henkvancann
Copy link
Author

henkvancann commented Apr 13, 2021

On today's meeting, Daniel mentioned that we can use the GH CDN to link directly to images already on github to reduce asset creep:

https://rawgit.org/ , for example, turns this the ION logo already in the sidetree repo:
https://github.com/decentralized-identity/sidetree/blob/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png
into this:
https://ghcdn.rawgit.org/decentralized-identity/sidetree/9fac9173f1bce193a7fe802aa1e59334befa160d/docs/images/what-is-ION.png
which can be linked from the QnA's

HvC: Yep, very good idea, however, work to be done after this PR as far as I am concerned.

Copy link
Member

@gjgd gjgd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Added a few suggestions

henkvancann and others added 8 commits May 24, 2021 18:30
Co-authored-by: gjgd <7913565+gjgd@users.noreply.github.com>
Co-authored-by: gjgd <7913565+gjgd@users.noreply.github.com>
Co-authored-by: gjgd <7913565+gjgd@users.noreply.github.com>
Co-authored-by: gjgd <7913565+gjgd@users.noreply.github.com>
Co-authored-by: gjgd <7913565+gjgd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants