Skip to content

Deadlock: if the callback on Each panics and the app has a recovery - issue 163 #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 10, 2025
Merged

Deadlock: if the callback on Each panics and the app has a recovery - issue 163 #164

merged 2 commits into from
Jun 10, 2025

Conversation

deckarep
Copy link
Owner

@deckarep deckarep commented Jun 6, 2025 •
edited
Loading

  • Ensures the read lock is still unlocked if a panic occurs within the callback of the Each function and a recovery handler runs.
  • Fixes the capacity hint in ToSlice by ensuring the Cardinality is read under the confines of the read lock.
  • Adds a unit test

@deckarep
Deadlock: if the callback on Each panics and the app has a recovery, …
0e60d36 
…this will ensure that the thread-safe set is left in a usable state by ensuring the read lock is Unlocked. This also has a minor tweak on ToSlice to ensure the capacity hint is correct
@deckarep deckarep changed the title Deadlock: if the callback on Each panics and the app has a recovery - issue: https://github.com/deckarep/golang-set/issues/163 Deadlock: if the callback on Each panics and the app has a recovery - issue 163 Jun 6, 2025
@deckarep deckarep mentioned this pull request Jun 6, 2025
Open
hemflit
hemflit suggested changes Jun 9, 2025
View reviewed changes
Copy link

@hemflit hemflit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this quick resolution, and I'm sorry about the delay in getting back.

The production code LGTM 100%, it's just for the test code that I have one minor request for change and one recommendation.

@deckarep deckarep merged commit 9480c3e into main Jun 10, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hemflit hemflit hemflit requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deckarep @hemflit