Skip to content

Conversation

@astef
Copy link
Member

@astef astef commented Dec 11, 2024

Description

This is an improvement of tar, proposed here, then back-ported to v.4.7.0, and proposed in a form of a patch, replacing an older one.

Why do we need it, and what problem does it solve?

Older patch had a several problems:

  • not properly handling errors of file Close (sometimes ignoring them, sometimes silently returning success in the middle of the work)
  • not handling symlinks properly
  • Zip Slip vulnerability
  • bug, when --working-mount-dir is a relative path

What is the expected result?

No change in behavior, only bugs fixed.

Checklist

  • The code is covered by unit tests.
  • Changes were tested in the Kubernetes cluster manually.

Signed-off-by: Alexandr Stefurishin <[email protected]>
@astef astef added the enhancement New feature or request label Dec 11, 2024
@astef astef requested a review from AleksZimin December 11, 2024 20:09
@astef astef self-assigned this Dec 11, 2024
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
@AleksZimin AleksZimin merged commit 0e81b0f into main Dec 24, 2024
4 of 7 checks passed
@AleksZimin AleksZimin deleted the astef-improve-tar branch December 24, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants