Skip to content

[deckhouse-cli] fix: mirror: correct URL parsing for VEX images with port in registry address #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldmonster merged 4 commits into from
Dec 29, 2025
Merged

[deckhouse-cli] fix: mirror: correct URL parsing for VEX images with port in registry address #253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f7fb41e
fix: splitn bug
timmilesdw Dec 25, 2025
e0e18fb
fix: tests
timmilesdw Dec 25, 2025
634e637
fix: add segments to client
timmilesdw Dec 26, 2025
a0ab4f3
fix: tests
timmilesdw Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions pkg/libmirror/images/digests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,23 +195,32 @@ func FindVexImage(
return "", fmt.Errorf("parse reference: %w", err)
}

split := strings.SplitN(vexImageName, ":", 2)
imagePath := split[0]
tag := split[1]
// Use LastIndex to correctly handle URLs with port (e.g., localhost:443/repo:tag)
splitIndex := strings.LastIndex(vexImageName, ":")
if splitIndex == -1 {
return "", fmt.Errorf("invalid vex image name format: %s", vexImageName)
}
imagePath := vexImageName[:splitIndex]
tag := vexImageName[splitIndex+1:]

// Add missing path segments to client if VEX image is in a subpath
imageSegmentsRaw := strings.TrimPrefix(imagePath, client.GetRegistry())
imageSegments := strings.Split(imageSegmentsRaw, "/")

for i, segment := range imageSegments {
client = client.WithSegment(segment)
logger.Debugf("Segment %d: %s", i, segment)
imageSegmentsRaw = strings.TrimPrefix(imageSegmentsRaw, "/")
if imageSegmentsRaw != "" {
for _, segment := range strings.Split(imageSegmentsRaw, "/") {
client = client.WithSegment(segment)
logger.Debugf("Segment: %s", segment)
}
}

err = client.CheckImageExists(context.TODO(), tag)
if errors.Is(err, regclient.ErrImageNotFound) {
// Image not found, which is expected for non-vulnerable images
return "", nil
}
if err != nil {
return "", fmt.Errorf("check VEX image exists: %w", err)
}

return vexImageName, nil
}
25 changes: 17 additions & 8 deletions pkg/libmirror/layouts/layouts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,23 +493,32 @@ func FindVexImage(
return "", fmt.Errorf("parse reference: %w", err)
}

split := strings.SplitN(vexImageName, ":", 2)
imagePath := split[0]
tag := split[1]
// Use LastIndex to correctly handle URLs with port (e.g., localhost:443/repo:tag)
splitIndex := strings.LastIndex(vexImageName, ":")
if splitIndex == -1 {
return "", fmt.Errorf("invalid vex image name format: %s", vexImageName)
}
imagePath := vexImageName[:splitIndex]
tag := vexImageName[splitIndex+1:]

// Add missing path segments to client if VEX image is in a subpath
imageSegmentsRaw := strings.TrimPrefix(imagePath, client.GetRegistry())
imageSegments := strings.Split(imageSegmentsRaw, "/")

for i, segment := range imageSegments {
client = client.WithSegment(segment)
logger.Debugf("Segment %d: %s", i, segment)
imageSegmentsRaw = strings.TrimPrefix(imageSegmentsRaw, "/")
if imageSegmentsRaw != "" {
for _, segment := range strings.Split(imageSegmentsRaw, "/") {
client = client.WithSegment(segment)
logger.Debugf("Segment: %s", segment)
}
}

err = client.CheckImageExists(context.TODO(), tag)
if errors.Is(err, regclient.ErrImageNotFound) {
// Image not found, which is expected for non-vulnerable images
return "", nil
}
if err != nil {
return "", fmt.Errorf("check VEX image exists: %w", err)
}

return vexImageName, nil
}