Skip to content

[dmt] oss.yaml should be present only for those modules that have the images folder#341

Merged
ldmonster merged 5 commits intomainfrom
oss-yaml-fix
Feb 2, 2026
Merged

[dmt] oss.yaml should be present only for those modules that have the images folder#341
ldmonster merged 5 commits intomainfrom
oss-yaml-fix

Conversation

@RottenRat
Copy link
Contributor

@RottenRat RottenRat commented Jan 30, 2026

No images -> nothing to license -> oss.yaml is not needed
Tests:
Before:
Case: No images dir

🐒 [oss (#module)]
     Message:      Module should have oss.yaml
     Module:       test
     FilePath:     /test/test/oss.yaml

After:
All OK

Case: has images dir
Before:

🐒 [oss (#module)]
     Message:      Module should have oss.yaml
     Module:       test
     FilePath:     /test/test/oss.yaml

After:

(WARN)
🐒 [oss (#module)]
     Message:      module has images folder, so it likely should have oss.yaml
     Module:       test
     FilePath:     /test/test/oss.yaml

Case: has oss.yaml (empty) but have no images dir
Before:

🐒 [oss (#module)]
     Message:     no projects described
     Module:      test
     FilePath:     /test/test/oss.yaml

After
All OK

Else errors work same

Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
@RottenRat RottenRat self-assigned this Jan 30, 2026
@RottenRat RottenRat marked this pull request as ready for review January 30, 2026 10:39
@RottenRat RottenRat requested a review from ldmonster January 30, 2026 10:39
@RottenRat RottenRat changed the title [dmt] oss.yaml should be present only for those modules that have the images folder. [dmt] oss.yaml should be present only for those modules that have the images folder Jan 30, 2026
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
Signed-off-by: Sinelnikov Michail <mikhail.sinelnikov@flant.com>
@ldmonster ldmonster merged commit b6bf6d1 into main Feb 2, 2026
3 checks passed
@ldmonster ldmonster deleted the oss-yaml-fix branch February 2, 2026 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants