-
Notifications
You must be signed in to change notification settings - Fork 4
Prototype (v1alpha2) #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
astef
wants to merge
484
commits into
main
Choose a base branch
from
astef-prototype
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Prototype (v1alpha2) #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
…lvs get their new size Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Prototype ownerref
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Pavel Karpov <[email protected]> Signed-off-by: Ivan Ogurchenok <[email protected]> Signed-off-by: Slava V <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Pavel Karpov <[email protected]>
Signed-off-by: Ivan Ogurchenok <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
…resolve with nil handling Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Ivan Ogurchenok <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
[agent] Optimize DRBD status updates
…th limits (#483) Signed-off-by: David Magton <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
…o' instead of 'publishOn'. Update related conditions and controller logic to reflect the new attachment model. Introduce rv-attach-controller for managing replica attachment, including handling of conditions and scheduling. Update documentation and tests accordingly. Signed-off-by: David Magton <[email protected]>
Signed-off-by: David Magton <[email protected]>
…ttachment progress. Signed-off-by: David Magton <[email protected]>
…lume attachment retrieval. Introduced MatchingFields for efficient querying of ReplicatedVolumeAttachments by name, improving performance and clarity in the reconciler logic. Updated tests to reflect these changes. Signed-off-by: David Magton <[email protected]>
…e, ReplicatedVolumeReplica, and ReplicatedVolumeAttachment watches. This improves event filtering and ensures more efficient reconciliation processes. Signed-off-by: David Magton <[email protected]>
…s management. Updated reconciler logic and tests to replace string literals with defined constants for Pending, Attaching, Attached, and Detaching phases, enhancing code clarity and maintainability. Signed-off-by: David Magton <[email protected]>
… detail. Introduced new condition types for Attached and ReplicaIOReady, updating the reconciler logic to reflect these changes. Improved error handling in wait functions and tests to accommodate the new condition structure, ensuring accurate status reporting during attachment processes. Signed-off-by: David Magton <[email protected]>
…conciles to 10. This adjustment aims to improve the efficiency of the reconciliation process for ReplicatedVolumes, allowing for better resource management during attachment operations. Signed-off-by: David Magton <[email protected]>
…consistency. Updated comment styles to enhance readability and understanding of the reconciliation process, including fetching and computing logic for ReplicatedVolumes and their attachments. Signed-off-by: David Magton <[email protected]>
- Switch `hack/generate_code.sh` to `go run -mod=mod [email protected]` (no `go get` into the `api` module) - Regenerate `ReplicatedVolumeAttachment` CRD with controller-gen v0.19 (version annotation update) - Update `images/megatest` dependencies (go.mod/go.sum)
…a1 to images/controller/internal/indexes and update all controller/test usages accordingly. Simplify rv-attach-controller predicates by removing redundant type checks and using slices.Equal for finalizers comparison. Drop obsolete manual_cert_renewal_test.go. Signed-off-by: David Magton <[email protected]>
…dVolumeReplicas until the ReplicatedVolume becomes IOReady. Existing Primary replicas are left intact, and demotions remain allowed for safe detach-only operation. Add a unit test to ensure no Primary request is made before IOReady even when desiredAttachTo is pre-initialized. Signed-off-by: David Magton <[email protected]>
[controller] [agent] Rename “publish” to “attach” and introduce ReplicatedVolumeAttachment (RVA) resource
Signed-off-by: Aleksandr Stefurishin <[email protected]>
[agent] Resource file names should be named as RVRs to avoid deleting conflicting files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
What is the expected result?
Checklist