Skip to content

Conversation

@astef
Copy link
Member

@astef astef commented May 28, 2025

Description

Why do we need it, and what problem does it solve?

What is the expected result?

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Changes were tested in the Kubernetes cluster manually.
  • Documentation updated according to the changes.

@astef astef self-assigned this May 28, 2025
astef added 29 commits October 12, 2025 13:26
Signed-off-by: Aleksandr Stefurishin <[email protected]>
…lvs get their new size

Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
@krpsh123 krpsh123 marked this pull request as draft December 25, 2025 20:12
astef and others added 29 commits December 26, 2025 11:00
Signed-off-by: Pavel Karpov <[email protected]>
Signed-off-by: Ivan Ogurchenok <[email protected]>
Signed-off-by: Slava V <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Ivan Ogurchenok <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
…resolve with nil handling

Signed-off-by: Aleksandr Stefurishin <[email protected]>
Signed-off-by: Aleksandr Stefurishin <[email protected]>
[agent] Optimize DRBD status updates
…o' instead of 'publishOn'. Update related conditions and controller logic to reflect the new attachment model. Introduce rv-attach-controller for managing replica attachment, including handling of conditions and scheduling. Update documentation and tests accordingly.

Signed-off-by: David Magton <[email protected]>
…lume attachment retrieval. Introduced MatchingFields for efficient querying of ReplicatedVolumeAttachments by name, improving performance and clarity in the reconciler logic. Updated tests to reflect these changes.

Signed-off-by: David Magton <[email protected]>
…e, ReplicatedVolumeReplica, and ReplicatedVolumeAttachment watches. This improves event filtering and ensures more efficient reconciliation processes.

Signed-off-by: David Magton <[email protected]>
…s management. Updated reconciler logic and tests to replace string literals with defined constants for Pending, Attaching, Attached, and Detaching phases, enhancing code clarity and maintainability.

Signed-off-by: David Magton <[email protected]>
… detail. Introduced new condition types for Attached and ReplicaIOReady, updating the reconciler logic to reflect these changes. Improved error handling in wait functions and tests to accommodate the new condition structure, ensuring accurate status reporting during attachment processes.

Signed-off-by: David Magton <[email protected]>
…conciles to 10. This adjustment aims to improve the efficiency of the reconciliation process for ReplicatedVolumes, allowing for better resource management during attachment operations.

Signed-off-by: David Magton <[email protected]>
…consistency. Updated comment styles to enhance readability and understanding of the reconciliation process, including fetching and computing logic for ReplicatedVolumes and their attachments.

Signed-off-by: David Magton <[email protected]>
- Switch `hack/generate_code.sh` to `go run -mod=mod [email protected]` (no `go get` into the `api` module)
- Regenerate `ReplicatedVolumeAttachment` CRD with controller-gen v0.19 (version annotation update)
- Update `images/megatest` dependencies (go.mod/go.sum)
…a1 to images/controller/internal/indexes and update all controller/test usages accordingly. Simplify rv-attach-controller predicates by removing redundant type checks and using slices.Equal for finalizers comparison. Drop obsolete manual_cert_renewal_test.go.

Signed-off-by: David Magton <[email protected]>
…dVolumeReplicas until the ReplicatedVolume becomes IOReady. Existing Primary replicas are left intact, and demotions remain allowed for safe detach-only operation. Add a unit test to ensure no Primary request is made before IOReady even when desiredAttachTo is pre-initialized.

Signed-off-by: David Magton <[email protected]>
[controller] [agent] Rename “publish” to “attach” and introduce ReplicatedVolumeAttachment (RVA) resource
Signed-off-by: Aleksandr Stefurishin <[email protected]>
[agent] Resource file names should be named as RVRs to avoid deleting conflicting files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants