Ability to skip container mutation (for example for istio)#22
Merged
Conversation
e336e44 to
3621f05
Compare
Signed-off-by: Maksim Kiselev <maksim.kiselev@flant.com>
8cb41ef to
18dbbdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
secrets-store.deckhouse.io/skip-mutate-containerspod annotation or theskip_mutate_containerswebhook environment variable.Why do we need it, and what problem does it solve?
Istio initContainers do not have access to Vault when using the
secrets-store.deckhouse.io/env-from-pathannotation, so we want to skip such containers.What is the expected result?
Pods with the
secrets-store.deckhouse.io/env-from-pathannotation and thesidecar.istio.io/inject: "true"label can start successfully.Checklist