refactor(core): remove VM maintenance check for DryRun restore mode

- Remove ErrVMNotInMaintenance and ErrVMMaintenanceCondNotFound errors
- Remove maintenance condition check from vm_restorer.go for DryRun mode
- Remove DryRunIgnoredErrors from snapshot_resources.go

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>

Author: danilrwx

images/virtualization-artifact/pkg/controller/service/restorer/common/common.go

@@ -35,8 +35,6 @@ var (
 	ErrUpdating                    = errors.New("will be updated")
 	ErrQueueing                    = errors.New("will be queued")
 	ErrWaitingForDeletion          = errors.New("waiting for deletion to complete")
-	ErrVMNotInMaintenance          = errors.New("the virtual machine is not in maintenance mode")
-	ErrVMMaintenanceCondNotFound   = errors.New("the virtual machine maintenance condition is not found")
 	ErrVirtualImageNotFound        = errors.New("the virtual image is not found")
 	ErrVirtualDiskSnapshotNotFound = errors.New("not found")
 	ErrClusterVirtualImageNotFound = errors.New("the virtual image is not found")

images/virtualization-artifact/pkg/controller/service/restorer/restorers/vm_restorer.go

@@ -28,10 +28,8 @@ import (
 
 	"github.com/deckhouse/virtualization-controller/pkg/common/annotations"
 	"github.com/deckhouse/virtualization-controller/pkg/common/object"
-	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/service/restorer/common"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
-	"github.com/deckhouse/virtualization/api/core/v1alpha2/vmcondition"
 )
 
 const ReasonPVCNotFound = "PVC not found"
@@ -184,15 +182,6 @@ func (v *VirtualMachineHandler) ProcessRestore(ctx context.Context) error {
 	}
 
 	if vm != nil {
-		cond, found := conditions.GetCondition(vmcondition.TypeMaintenance, vm.Status.Conditions)
-		if !found {
-			return common.ErrVMMaintenanceCondNotFound
-		}
-
-		if cond.Status != metav1.ConditionTrue {
-			return common.ErrVMNotInMaintenance
-		}
-
 		// Early return if VM is already fully processed by this restore operation
 		if value, ok := vm.Annotations[annotations.AnnVMOPRestore]; ok && value == v.restoreUID {
 			if equality.Semantic.DeepEqual(vm.Spec, v.vm.Spec) {

images/virtualization-artifact/pkg/controller/service/restorer/snapshot_resources.go

@@ -292,11 +292,6 @@ func (r *SnapshotResources) Process(ctx context.Context) ([]v1alpha2.SnapshotRes
 	return r.statuses, nil
 }
 
-var DryRunIgnoredErrors = []error{
-	common.ErrVMMaintenanceCondNotFound,
-	common.ErrVMNotInMaintenance,
-}
-
 var BestEffortIgnoredErrors = []error{
 	common.ErrVirtualImageNotFound,
 	common.ErrClusterVirtualImageNotFound,
@@ -311,12 +306,6 @@ var RetryErrors = []error{
 
 func shouldIgnoreError(mode v1alpha2.SnapshotOperationMode, err error) bool {
 	switch mode {
-	case v1alpha2.SnapshotOperationModeDryRun:
-		for _, e := range DryRunIgnoredErrors {
-			if errors.Is(err, e) {
-				return true
-			}
-		}
 	case v1alpha2.SnapshotOperationModeBestEffort:
 		for _, e := range BestEffortIgnoredErrors {
 			if errors.Is(err, e) {

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_clone_step.go

@@ -21,19 +21,16 @@ import (
 	"errors"
 
 	corev1 "k8s.io/api/core/v1"
-	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/types"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
 
 	"github.com/deckhouse/virtualization-controller/pkg/common/annotations"
 	"github.com/deckhouse/virtualization-controller/pkg/common/object"
-	"github.com/deckhouse/virtualization-controller/pkg/controller/conditions"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/service/restorer"
 	"github.com/deckhouse/virtualization-controller/pkg/controller/service/restorer/common"
 	"github.com/deckhouse/virtualization-controller/pkg/eventrecord"
 	"github.com/deckhouse/virtualization/api/core/v1alpha2"
-	"github.com/deckhouse/virtualization/api/core/v1alpha2/vmopcondition"
 )
 
 type ProcessCloneStep struct {
@@ -52,11 +49,6 @@ func NewProcessCloneStep(
 }
 
 func (s ProcessCloneStep) Take(ctx context.Context, vmop *v1alpha2.VirtualMachineOperation) (*reconcile.Result, error) {
-	cond, found := conditions.GetCondition(vmopcondition.TypeCompleted, vmop.Status.Conditions)
-	if found && cond.Status == metav1.ConditionTrue {
-		return nil, nil
-	}
-
 	snapshotName, ok := vmop.Annotations[annotations.AnnVMOPSnapshotName]
 	if !ok {
 		return &reconcile.Result{}, errors.New("snapshot name annotation not found")

images/virtualization-artifact/pkg/controller/vmop/snapshot/internal/step/process_restore_step.go

@@ -51,11 +51,6 @@ func NewProcessRestoreStep(
 }
 
 func (s ProcessRestoreStep) Take(ctx context.Context, vmop *v1alpha2.VirtualMachineOperation) (*reconcile.Result, error) {
-	cond, found := conditions.GetCondition(vmopcondition.TypeCompleted, vmop.Status.Conditions)
-	if found && cond.Status == metav1.ConditionTrue {
-		return nil, nil
-	}
-
 	maintenanceModeCondition, found := conditions.GetCondition(vmopcondition.TypeMaintenanceMode, vmop.Status.Conditions)
 	if vmop.Spec.Restore.Mode != v1alpha2.SnapshotOperationModeDryRun && (!found || maintenanceModeCondition.Status == metav1.ConditionFalse) {
 		return &reconcile.Result{}, nil