Skip to content

Comments

fix(vmop): restore with snapshot from saved VD#1694

Closed
danilrwx wants to merge 3 commits intomainfrom
fix/vmop/restore-with-sc-of-snapshot-vd
Closed

fix(vmop): restore with snapshot from saved VD#1694
danilrwx wants to merge 3 commits intomainfrom
fix/vmop/restore-with-sc-of-snapshot-vd

Conversation

@danilrwx
Copy link
Contributor

@danilrwx danilrwx commented Nov 13, 2025

Description

Fixes an issue where a disk in a snapshot does not have a storage class in the spec. During restore from snapshot we miss that storageClass and use default, which it incorrect.

Why do we need it, and what problem does it solve?

With this fix, if there is no storageClass in the spec, we will take the class from the status.

What is the expected result?

Using origin storageClass.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmop
type: fix
summary: Using storageClass of VD from status or spec during VMOP Restore or Clone.

Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
Signed-off-by: Daniil Antoshin <daniil.antoshin@flant.com>
@danilrwx danilrwx marked this pull request as ready for review November 14, 2025 12:26
@danilrwx danilrwx added this to the v1.2.0 milestone Nov 14, 2025
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 17, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 17, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 17, 2025
@danilrwx danilrwx added the e2e/run Run e2e test on cluster of PR author label Nov 18, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Nov 18, 2025

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Nov 18, 2025
@Isteb4k Isteb4k modified the milestones: v1.2.0, v1.3.0 Nov 26, 2025
@danilrwx danilrwx closed this Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants