chore(module): dvcr gc provisioners waiting timeout#1740
Merged
Conversation
d1cf5df to
dfcfd25
Compare
Isteb4k
requested changes
Nov 28, 2025
images/virtualization-artifact/pkg/controller/dvcr-garbage-collection/internal/life_cycle.go
Outdated
Show resolved
Hide resolved
- Cancel garbage collection if wait for provisioners more than 2 hours. Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
dfcfd25 to
ddf1ee6
Compare
Isteb4k
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Why do we need it, and what problem does it solve?
Provisioners may work at the beginning of garbage collection and controller waits until all provisioners are finished. This wait process should have timeout.
What is the expected result?
GC cancels if provisioners are not finished, condition is set.
Checked with 2m timeout:
Checklist
Changelog entries