Skip to content

Comments

feat(vmclass): add defaultCoreFraction field#1783

Merged
eofff merged 10 commits intomainfrom
feat/vmclass/add-corefraction-default
Dec 9, 2025
Merged

feat(vmclass): add defaultCoreFraction field#1783
eofff merged 10 commits intomainfrom
feat/vmclass/add-corefraction-default

Conversation

@eofff
Copy link
Contributor

@eofff eofff commented Dec 3, 2025 •
edited by Isteb4k
Loading

Description

Add defaultCoreFraction field for sizing policy.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vmclass
type: feature
summary: Added the `.spec.sizingPolicies.defaultCoreFraction` field to the `VirtualMachineClass` resource, allowing you to set the default `coreFraction` for virtual machines that use this class.

@eofff eofff force-pushed the feat/vmclass/add-corefraction-default branch 2 times, most recently from 6b17a38 to 70875e6 Compare December 3, 2025 19:42
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Dec 3, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 3, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 3, 2025
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Dec 4, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 4, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 4, 2025
Valeriy Khorunzhin added 3 commits December 5, 2025 16:02
t
a958594 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
t1
0bbab48 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
regenerate
620ec37 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff force-pushed the feat/vmclass/add-corefraction-default branch from 7676366 to 620ec37 Compare December 5, 2025 13:02
@eofff eofff added the e2e/run Run e2e test on cluster of PR author label Dec 5, 2025
@deckhouse-BOaTswain
Copy link
Contributor

deckhouse-BOaTswain commented Dec 5, 2025 •
edited
Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

@deckhouse-BOaTswain deckhouse-BOaTswain removed the e2e/run Run e2e test on cluster of PR author label Dec 5, 2025
@eofff eofff changed the title add feat(vmclass): add defaultCoreFraction field Dec 8, 2025
@eofff eofff added this to the v1.3.0 milestone Dec 8, 2025
@eofff eofff requested a review from loktev-d December 8, 2025 09:13
fix doc
364306e 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff marked this pull request as ready for review December 8, 2025 09:29
resolve
e785adb 
Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
@eofff eofff requested a review from loktev-d December 8, 2025 13:51
@z9r5 z9r5 requested a review from prismagod December 8, 2025 15:03
loktev-d
loktev-d previously approved these changes Dec 9, 2025
View reviewed changes
prismagod
prismagod reviewed Dec 9, 2025
View reviewed changes
prismagod
prismagod reviewed Dec 9, 2025
View reviewed changes
prismagod
prismagod reviewed Dec 9, 2025
View reviewed changes
prismagod
prismagod reviewed Dec 9, 2025
View reviewed changes
@eofff @prismagod
Update crds/doc-ru-virtualmachineclasses.yaml
5dbde72 
Co-authored-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Signed-off-by: Valeriy Khorunzhin <b1kapb999@gmail.com>
eofff and others added 3 commits December 9, 2025 11:28
@eofff @prismagod
Update crds/virtualmachineclasses.yaml
c78a89a 
Co-authored-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Signed-off-by: Valeriy Khorunzhin <b1kapb999@gmail.com>
@eofff @prismagod
Update crds/virtualmachineclasses.yaml
88e1eba 
Co-authored-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Signed-off-by: Valeriy Khorunzhin <b1kapb999@gmail.com>
@eofff @prismagod
Update crds/doc-ru-virtualmachines.yaml
8aaa8e9 
Co-authored-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
Signed-off-by: Valeriy Khorunzhin <b1kapb999@gmail.com>
prismagod
prismagod reviewed Dec 9, 2025
View reviewed changes
@prismagod
Review
a0a7e77 
Signed-off-by: Vladislav Panfilov <97229646+prismagod@users.noreply.github.com>
@eofff eofff merged commit 35d1288 into main Dec 9, 2025
22 of 23 checks passed
@eofff eofff deleted the feat/vmclass/add-corefraction-default branch December 9, 2025 08:35
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 9, 2025
Merged
@deckhouse-BOaTswain deckhouse-BOaTswain mentioned this pull request Dec 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Isteb4k Isteb4k Isteb4k left review comments

@prismagod prismagod prismagod approved these changes

@loktev-d loktev-d loktev-d left review comments

@yaroslavborbat yaroslavborbat Awaiting requested review from yaroslavborbat yaroslavborbat is a code owner

@fl64 fl64 Awaiting requested review from fl64 fl64 is a code owner

@z9r5 z9r5 Awaiting requested review from z9r5

@goganat goganat Awaiting requested review from goganat goganat is a code owner

Assignees

@eofff eofff

Labels

None yet

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

5 participants

@eofff @deckhouse-BOaTswain @loktev-d @Isteb4k @prismagod