feat(vm): check default value#1817

Merged

eofff merged 5 commits intomainfrom

feat/vm/check-if-default-not-allowed

Dec 12, 2025

Contributor

eofff commented Dec 11, 2025 •

edited

Loading

Description

Check whether 100% is present in the available coreFraction values if the default is not specified.

Checklist

The code is covered by unit tests.
e2e tests passed.
Documentation updated according to the changes.
Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: vm
type: feature
summary: Check whether 100% is present in the available coreFraction values if the default is not specified.
impact_level: low


          add check

939d791

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

eofff requested review from Isteb4k and yaroslavborbat as code owners

December 11, 2025 12:52

eofff self-assigned this

eofff added this to the v1.3.0 milestone

Valeriy Khorunzhin added 2 commits

December 11, 2025 16:15


          refactoring

b71b688

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>


          refactoring

6df703c

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

Isteb4k requested changes

View reviewed changes

images/virtualization-artifact/pkg/controller/vm/internal/defaulter/core_fraction.go Outdated Show resolved Hide resolved

images/virtualization-artifact/pkg/controller/vm/internal/defaulter/core_fraction.go Outdated Show resolved Hide resolved


          msgs

4e2eda6

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

eofff requested a review from Isteb4k

December 11, 2025 15:27


          quotas

c152a93

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>

eofff added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 11, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

Isteb4k approved these changes

View reviewed changes

eofff added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 12, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 12, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

eofff added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 12, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

eofff added the e2e/run label

Contributor

deckhouse-BOaTswain commented Dec 12, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

eofff added e2e/user/danilrwx e2e/run labels

Contributor

deckhouse-BOaTswain commented Dec 12, 2025 •

edited

Loading

Workflow has started.
Follow the progress here: Workflow Run

The target step completed with status: failure.

deckhouse-BOaTswain removed the e2e/run label

eofff merged commit 18bb590 into main

321 of 344 checks passed

eofff deleted the feat/vm/check-if-default-not-allowed branch

December 12, 2025 20:59

Isteb4k pushed a commit that referenced this pull request


          feat(vm): check default value (#1817)

fb3accb

Signed-off-by: Valeriy Khorunzhin <valeriy.khorunzhin@flant.com>
(cherry picked from commit 18bb590)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

e2e/user/danilrwx